Move import to when needed to avoid circular dependency error (#19579) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oft#19579) ### Description Move import to when needed to avoid circular dependency error ### Motivation and Context Fixes dependency error described here: microsoft/DeepSpeed#5140 --------- Co-authored-by: Thiago Crepaldi <[email protected]>
|
LGTM @rraminen , please also push to upstream master and the ROCm:rocm6.2_internal_testing. |
groenenboomj
merged commit 1caf382
into
ROCm:rocm6.1_internal_testing
7 of 17 checks passed
@groenenboomj, this change is already in upstream master and ROCm:rocm6.2_internal_testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move import to when needed to avoid circular dependency error
Motivation and Context
Fixes DeepSpeed dependency error:
AttributeError: partially initialized module 'deepspeed.comm' has no attribute 'ProcessGroup' (most likely due to a circular import)