Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also parse time from router certs #142

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Also parse time from router certs #142

merged 3 commits into from
Jan 10, 2024

Conversation

ties
Copy link
Member

@ties ties commented Jan 10, 2024

  • I have updated the changelog in README.md

lolepezy
lolepezy requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@lolepezy lolepezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for typo in the readme

README.md Outdated Show resolved Hide resolved
@ties
Copy link
Member Author

ties commented Jan 10, 2024

@lolepezy done

@lolepezy lolepezy self-requested a review January 10, 2024 11:53
@lolepezy lolepezy merged commit 78090bf into main Jan 10, 2024
6 checks passed
@lolepezy lolepezy deleted the fix/also-parse-time-from-router-certs branch January 10, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolepezy lolepezy lolepezy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ties @lolepezy