Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumping ERROR messages (eg. in RIOT using [^1]) makes SYNC messages show. While they are much rarer than the rest of the INFO level output, they're still not errors. So, let's either demote them to info or introduce more fine grained logging. Either way, chances are there are other similar errors that should be rolled up in this PR.
It'd be tempting to go a step further and make it print the output in hex, eg. using
but the
#include <format>
header would at least require c++23 and we're currently at 14. (Yes there is<< std::hex << params.syncParentShortAddress
, but I loathe that mechanism's statefulness).[^1]: Enabling error logging in RIOT