-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: don't ignore failures in for loops and minor cleanups for oonf_api #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apply 9b61d95 to oonf_api
benpicco
changed the title
make: don't ignore failures in for loops
make: don't ignore failures in for loops and minor cleanups for oonf_api
Mar 17, 2014
use reset --hard to check out the desired revision
remove leftovers from the example Makefile, they are unnededly printed during the build
Error handling here would be a plus: |
Adding something like https://github.com/RIOT-OS/RIOT/blob/master/pkg/libcoap/Makefile#L33 would help, I guess. |
like this? |
|
added |
ACK |
benpicco
added a commit
that referenced
this pull request
Mar 19, 2014
make: don't ignore failures in for loops, fix build with make 4.0 and minor cleanups
benpicco
added a commit
to benpicco/RIOT
that referenced
this pull request
Mar 19, 2014
Change the example Makefile.git as suggested in RIOT-OS#895 abort when a patch fails to apply fix build with GNU Make 4.0 reset git to the specified version instead of checking out a detached head
Merged
kaspar030
pushed a commit
to kaspar030/RIOT
that referenced
this pull request
Apr 3, 2014
Change the example Makefile.git as suggested in RIOT-OS#895 abort when a patch fails to apply fix build with GNU Make 4.0 reset git to the specified version instead of checking out a detached head
dangnhat
pushed a commit
to vanhieubk/RIOT
that referenced
this pull request
Apr 25, 2014
Change the example Makefile.git as suggested in RIOT-OS#895 abort when a patch fails to apply fix build with GNU Make 4.0 reset git to the specified version instead of checking out a detached head
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply 9b61d95 to oonf_api as suggested in #884
also silence some warnings and verbosity