Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: don't ignore failures in for loops and minor cleanups for oonf_api #895

Merged
merged 6 commits into from
Mar 19, 2014

Conversation

benpicco
Copy link
Contributor

apply 9b61d95 to oonf_api as suggested in #884
also silence some warnings and verbosity

@benpicco benpicco changed the title make: don't ignore failures in for loops make: don't ignore failures in for loops and minor cleanups for oonf_api Mar 17, 2014
use reset --hard to check out the desired revision
remove leftovers from the example Makefile, they are unnededly printed during the build
@LudwigKnuepfer
Copy link
Member

Error handling here would be a plus:
https://github.com/benpicco/RIOT/blob/oonf_fix/pkg/oonf_api/Makefile#L25

@OlegHahm OlegHahm added this to the Release 2014.04 milestone Mar 18, 2014
@OlegHahm
Copy link
Member

Adding something like https://github.com/RIOT-OS/RIOT/blob/master/pkg/libcoap/Makefile#L33 would help, I guess.

@benpicco
Copy link
Contributor Author

like this?

@LudwigKnuepfer
Copy link
Member

git am --abort ?

@benpicco
Copy link
Contributor Author

added

@LudwigKnuepfer
Copy link
Member

ACK

benpicco added a commit that referenced this pull request Mar 19, 2014
make: don't ignore failures in for loops, fix build with make 4.0 and minor cleanups
@benpicco benpicco merged commit 872ce5f into RIOT-OS:master Mar 19, 2014
@benpicco benpicco deleted the oonf_fix branch March 19, 2014 15:09
benpicco added a commit to benpicco/RIOT that referenced this pull request Mar 19, 2014
Change the example Makefile.git as suggested in RIOT-OS#895
  abort when a patch fails to apply
  fix build with GNU Make 4.0
  reset git to the specified version instead of checking out a detached head
@benpicco benpicco mentioned this pull request Mar 19, 2014
kaspar030 pushed a commit to kaspar030/RIOT that referenced this pull request Apr 3, 2014
Change the example Makefile.git as suggested in RIOT-OS#895
  abort when a patch fails to apply
  fix build with GNU Make 4.0
  reset git to the specified version instead of checking out a detached head
dangnhat pushed a commit to vanhieubk/RIOT that referenced this pull request Apr 25, 2014
Change the example Makefile.git as suggested in RIOT-OS#895
  abort when a patch fails to apply
  fix build with GNU Make 4.0
  reset git to the specified version instead of checking out a detached head
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants