sys/net/gnrc_pktbuf: detect use after free if canary is in metadata #21000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
When debugging #20983 this was quite useful to find the issue where a pointer to a pktsnip that was already freed was being held.
For the
!CONFIG_GNRC_PKTBUF_CHECK_USE_AFTER_FREE
this is already caught by theassert(pkt->users > 0)
, so if we turn on more extensive leak detection, don't degrade this case.Testing procedure
Issues/PRs references