gnrc_netif: fix packet leak with gnrc_netif_pktq & netdev_new_api [backport 2024.10] #20997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20983
Contribution description
With
netdev_new_api
packets are not released on send anymore.gnrc_netif_pktq
adds a hold on a packet to not release it on send.Even though 1 + 1 - 1 - 1 should be 0, we are leaking packets on send.
Testing procedure
Run a driver that makes use of both
netdev_new_api
andgnrc_netif_pktq
(e.g.at86rf215
):master
pktbuf stats
this PR
pktbuf is empty
Issues/PRs references
#11263 (comment)
fixes #17924