Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sixlowpan/ipv6: Simplify sending of ICMPv6 packets for sixlowpan neighbor discovery #166

Closed
miri64 opened this issue Aug 19, 2013 · 6 comments
Assignees
Labels
Area: network Area: Networking State: won't fix State: The issue can not or will not be fixed Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: question The issue poses a question regarding usage of RIOT

Comments

@miri64
Copy link
Member

miri64 commented Aug 19, 2013

By now, the functions for sending ICMPv6 packets (icmpv6_send_* in sixlowpan/icmp.h) using one 8-bit number as parameter for every possible option they can carry and the options are then set very rigid (and in some cases redundant) by those functions. A more configurable and less parameter demanding solution might be more sufficient.

@OlegHahm
Copy link
Member

I like the "more sufficient" part. scnr

@mehlis
Copy link
Contributor

mehlis commented Feb 24, 2014

follow up for #644

@kaspar030
Copy link
Contributor

(sixlowpan: ...)

@mehlis mehlis changed the title Simplify sending of ICMPv6 packets for sixlowpan neighbor discovery sixlowpan: Simplify sending of ICMPv6 packets for sixlowpan neighbor discovery May 4, 2014
@mehlis
Copy link
Contributor

mehlis commented May 4, 2014

@authmillenon is this idea still valid?

@mehlis mehlis added this to the Release NEXT MAJOR milestone May 4, 2014
@miri64
Copy link
Member Author

miri64 commented May 6, 2014

Yes.

@miri64 miri64 changed the title sixlowpan: Simplify sending of ICMPv6 packets for sixlowpan neighbor discovery sixlowpan/ipv6: Simplify sending of ICMPv6 packets for sixlowpan neighbor discovery May 6, 2014
@OlegHahm OlegHahm modified the milestones: FIX ME FIRST, Release NEXT MAJOR Jun 3, 2014
@OlegHahm OlegHahm assigned miri64 and unassigned OlegHahm Jun 18, 2014
@miri64
Copy link
Member Author

miri64 commented May 26, 2015

"Fixed" in new network stack.

@miri64 miri64 closed this as completed May 26, 2015
@OlegHahm OlegHahm added the State: won't fix State: The issue can not or will not be fixed label May 26, 2015
CW-75 pushed a commit to CW-75/RIOT that referenced this issue Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking State: won't fix State: The issue can not or will not be fixed Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Type: question The issue poses a question regarding usage of RIOT
Projects
None yet
Development

No branches or pull requests

4 participants