Merge pull request #20288 from kaspar030/fix_check_commits

ci: ensure "xxx succeeded" properly fail
RIOT-OS · Jan 23, 2024 · 7bec6cb · 7bec6cb
2 parents 2bf4611 + 5a16b63
commit 7bec6cb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/check-commits.yml b/.github/workflows/check-commits.yml
@@ -28,8 +28,10 @@ jobs:
         ./dist/tools/${{ matrix.check }}/check.sh "${{ github.base_ref }}"
   check-commits-success:
     needs: check-commits
-    if: github.event_name != 'merge_group'
+    if: always() && github.event_name != 'merge_group'
     runs-on: ubuntu-latest
     steps:
     - name: check-commits succeeded
-      run: exit 0
+      uses: re-actors/alls-green@release/v1
+      with:
+        jobs: ${{ toJSON(needs) }}
diff --git a/.github/workflows/tools-buildtest.yml b/.github/workflows/tools-buildtest.yml
@@ -60,9 +60,11 @@ jobs:
       with:
         cmd: make -C ${{ matrix.tools.path }}/${{ matrix.tools.name }}
   tools-build-success:
-    # this is only run if all jobs in tools-build succeeded
+    if: always()
     needs: tools-build
     runs-on: ubuntu-latest
     steps:
     - name: tools-build succeeded
-      run: exit 0
+      uses: re-actors/alls-green@release/v1
+      with:
+        jobs: ${{ toJSON(needs) }}