-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geom_stats static location #73
Comments
Interesting, I believe this should be what the |
After 0cdb186, adding Additionally, @mikejiang , it looks like there was already logic to automatically set Examples below: Setup:
Position: default -- center of gate
Position: lower left with respect to center of gate range
Position: center of full data range
Position: lower left with respect to center of full data range
Note this is still not with respect to the range of the window (just the data):
|
Hi @jacobpwagner, Thanks for that fix. It's working better, as the label moves less, but it still gets moved off of the plot sometimes when the populations shown are atypical. Adding the static argument would be great, but as time allows. |
Hi @alexheubeck. I'll get to work on the static option. Just out of curiosity, could you show a case where the label is getting moved off the plot? I just want to also make sure that that last fix is behaving as expected. |
Gotcha. And are you using I'm adding an argument that determines what range to use to determine the starting point for the label. It will allow the 3 options:
As a user, if there's a name for this argument (and the whole plot range option) that makes the most sense, I'd be happy to get your input. Currently, I'm using |
I am using
(Sorry it's a mess) I think |
Cool, I'll go with
you could instead do this:
Does that sound about right? That seems like a pretty reasonable request and addition. |
Yeah that's perfect, thanks! |
Alright, after f0a4d42, this is now possible. Here are some examples using the same setup as before. I include the Default positioning
Lower left within gate (
Lower left within data range
Lower left within range of plot axis limits
Fixed location
Of course, there's also nothing really stopping you from pushing the annotation outside of whatever window by going beyond 1.0 or below 0.0. For example:
|
Thanks @jacobpwagner, this is perfect. To that last point, I set the |
Agreed. I actually meant to do that and then forgot. Now it's included. |
Looks like the Using this line:
The label is placed properly: Using this line, where the "CD3-CD19-CD56- Cells" gate is a boolean NOT gate of the "NK Cells" gate:
I get this error:
Where BUV661-A is the channel for x axis in this plot |
Sorry about that. I think I know the issue. I'll try to get it fixed quickly. |
@alexheubeck , will you try again after 333c61f? I think that should solve the issue. Note that for |
@jacobpwagner, It's working now. Thank you once again for your help with this! |
Hi @jacobpwagner,
I had a quick question about using
geom_stats
. I am trying to plot a boolean NOT gate with ggcyto, and display the stats for that population. I'm using theadjust
parameter to change the location of the gate info. However, since it is relative to centroid of the population, the stats box is moving around a lot more than I'd like when the population shifts more than usual. Is there a way to have a static position for thegeom_stats
info on a plot? I saw that you could add arguments fromgeom_label
, but I couldn't get anything to work.Here's an example where the 'Non-Treg' population is a boolean NOT gate of the 'Treg' gate:
Thanks,
Alex
The text was updated successfully, but these errors were encountered: