Skip to content

Latest commit

 

History

History
44 lines (33 loc) · 1.87 KB

pull_request_template.md

File metadata and controls

44 lines (33 loc) · 1.87 KB

Description

Related PRs

PR Checklist for reviewer

General (all modules):

  • Build it on your own local instance and test new features or changes.
  • Pass UITesting on local and the matching UITesting branch.
  • All jest tests are passing
  • Is it functional and meets the requirements?
  • Are any shorthand variable or function names included in the Glossary?
  • Does it include descriptive code comments?
  • Does it follow the Style Guide?
    • No eslint warnings
  • Does it have any new dependencies? Is it justifiable?
  • Is there code duplication that could be reduced?
  • Are there performance improvements that could be made?

@immunespace/components:

  • Stories for each new component
  • Tests for each new component
  • Components are fully typed

When PR is approved:

  • bump version
  • merge to dev
  • publish to npm with dev tag
  • update LKM to point to dev tag