Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action bug + semver #270

Open
1 of 2 tasks
lalewis1 opened this issue Oct 1, 2024 · 5 comments
Open
1 of 2 tasks

github action bug + semver #270

lalewis1 opened this issue Oct 1, 2024 · 5 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@lalewis1
Copy link
Collaborator

lalewis1 commented Oct 1, 2024

todo

- [ ] fix bug in current CI action

  • implement semantic versioning
  • implement semantic release
@lalewis1 lalewis1 added bug Something isn't working enhancement New feature or request labels Oct 1, 2024
@lalewis1 lalewis1 self-assigned this Oct 1, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Prez Board Oct 1, 2024
@lalewis1
Copy link
Collaborator Author

lalewis1 commented Nov 1, 2024

Not sure if this is the same error that was happening previously. But the CI build is failing again after #294

Screenshot From 2024-11-01 14-14-55

It claims that cargo is required (see image) . not sure I believe that though.

I can build locally and its fine. Only difference I can see is in the docker version.

> action is using  26.1.3 and my laptop has 27.3.1

Just wondering if @recalcitrantsupplant or @ashleysommer know what is happening from last time the build was failing, as maybe it is the same thing happening again.

NOTE: Significant change in that PR was an upgrade to the pyoxigraph version.

Also, note that I have realized that the build action is actually building using python 3.11 not 3.12. It does this locally too but still builds successfully so it is not the cause of the current issue, but definitely will be a gotcha later. so just flagging it here as something else to be fixed.

@recalcitrantsupplant
Copy link
Collaborator

The wheel for pyoxigraph is not being built for arm (timing out) on the latest version of pyoxigraph, so there's no package on pypi
The build is still working for amd 64

I would suggest we wait for the issue to be resolved in pyoxigraph
If we really need the arm version we could build from source in the dockerfile

@recalcitrantsupplant
Copy link
Collaborator

@lalewis1 fyi oxigraph/oxigraph#1077

I think the arm based runners won't be available until early next year, it's likely we should do a release before then, so perhaps we allow the arm build to fail without affecting the amd64 (e.g. separate steps in the action, not sure on the specifics). I won't action this until we need a release though

@lalewis1
Copy link
Collaborator Author

lalewis1 commented Nov 6, 2024

semver implemented in #297

other bug still to be fixed

@lalewis1
Copy link
Collaborator Author

noting that there is still a bug with semver, whereby it cannot write to a protected branch. I'm thinking the best solution will be to remove the changelog and pyproj version changes so that no commit is needed by semver to complete the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants