Fix: Resolve Issues in RestKafkaSender and SchemaRetriever #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two key issues:
1.
TypeInfoErrors inRestKafkaSender:The current approach using reflection and generics to set TypeInfo results in errors when using with
radar-commons-android. This has been replaced with an implementation based on ParameterizedType, which is error-free.2. SchemaRetriever Metadata Behavior:
The
ContentConvertersimplementation utilizesSchemaRetriever::metadata, which sends a POST request to the /subject/topic_name endpoint, resulting in a 503 Service Unavailable error.This behavior was not observed in previous versions, previously, a GET request was sent to the
/subject/topic_name-key|valueendpoint if that fails, then the POST is used.These changes have been tested and work seamlessly with RADAR-pRMT. Suggestions for alternative solutions are welcome.