Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress ModuleNotFound for specific platforms #2

Open
smontanaro opened this issue Dec 9, 2022 · 3 comments
Open

Suppress ModuleNotFound for specific platforms #2

smontanaro opened this issue Dec 9, 2022 · 3 comments

Comments

@smontanaro
Copy link

While it occurs to me, most of the ModuleNotFound reasons in my initial example run are for Windows-only modules. As I'm on Mac (or Linux), it would be nice to suppress missing platform-specific modules for other platforms. Even if I'm interested in winreg, it makes sense to suppress that warning on Linux or Mac, as it's simply never going to be found.

@R9295
Copy link
Owner

R9295 commented Dec 9, 2022

Thanks for the suggestion, by warning I assume you mean the AAAA could not resolve x module message?

@smontanaro
Copy link
Author

I was thinking of this json entry:

                {
                    "reason": "ModuleNotFoundError",
                    "name": "winreg"
                },

On anything other than a Windows machine, I think it's effectively a false positive.

@R9295
Copy link
Owner

R9295 commented Dec 10, 2022

I see, that makes sense, but would it not be confusing if the module has no sub-dependencies while the rest do?
One way to handle it could be with a different reason message, for example, reason: "PlatformSpecificModule"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants