-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Mod information #899
refactor: Mod information #899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On vc yesterday, Blue told NSGetModVersions
and NSIsModRequiredOnClient
methods are now useless, as all mod information should be accessed through NSGetModsInformation
.
While I agree about NSIsModRequiredOnClient
, I still think NSGetModVersions
is required, notably in the main menu (we don't want to fetch info from all mods to display Northstar current version).
@RoyalBlue1 wdyt?
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Maybe instead |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM changes all the uses of the singular functions to get mod info to the struct
Mod counterpart of R2Northstar/NorthstarLauncher#826.