Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractClientPlayerEntity#getSpeed is poorly named #484

Open
OroArmor opened this issue Aug 28, 2023 · 2 comments · May be fixed by #667
Open

AbstractClientPlayerEntity#getSpeed is poorly named #484

OroArmor opened this issue Aug 28, 2023 · 2 comments · May be fixed by #667
Labels
enhancement new feature or request good first issue good for new contributors help wanted extra attention is needed t: refactor proposes a refactor

Comments

@OroArmor
Copy link
Member

It has to do with FOV modification, and mojmap is getFieldOfViewModifier. Can 100% have a better name.
@OroArmor OroArmor added enhancement new feature or request good first issue good for new contributors help wanted extra attention is needed t: refactor proposes a refactor labels Aug 28, 2023
@mdfarhananwar
Copy link

I want to work on this. Can you assign me this task?

@ix0rai
Copy link
Member

ix0rai commented Aug 28, 2023

don't worry about it; just make a pr and it'll be linked here when open

I like the moj name but we should double check that it's a modifier and not a multiplier

@maloryware maloryware linked a pull request Nov 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement new feature or request good first issue good for new contributors help wanted extra attention is needed t: refactor proposes a refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Miscellaneous refactorings maloryware/quilt-mappings
3 participants
@OroArmor @ix0rai @mdfarhananwar