Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up Numbers #20

Open
QuickWrite opened this issue Mar 13, 2023 · 2 comments
Open

Speed up Numbers #20

QuickWrite opened this issue Mar 13, 2023 · 2 comments
Assignees
@QuickWrite
Labels
enhancement New feature or request

Comments

@QuickWrite
Copy link
Owner

It seems like numbers themselves are quite slow. This should be fixed.
@QuickWrite QuickWrite added the enhancement New feature or request label Mar 13, 2023
@QuickWrite QuickWrite self-assigned this Mar 13, 2023
@QuickWrite
Copy link
Owner Author

It seems like the problem lies in the instantiation of the Numbers in the ArgumentContainer and it lies in the implementation of ICUs library. Maybe there is a way to avoid that instantiation completely.

@QuickWrite
Copy link
Owner Author

But it seems like the numbers are getting cached. This is good and bad at the same time as it means that the developers of that library know that this is a problem and they have done a more-or-less hacky solution so that that problem does not really occur that often.
This is good as many numbers occur quite often, but sometimes new numbers will appear which means that the slowdown is there again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuickWrite QuickWrite

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QuickWrite