-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Not yet finished] Fix wattmeter probe #946
base: release-0.0.20
Are you sure you want to change the base?
Conversation
ah, the joys of CI...
any idea is appreciated... |
uh, there's still something wrong: as described in the Qucs docs, "all voltages and currents are peak values" (see pag 13) so the AC power results should be divided by 2. But for DC simulations not. So the results shown in Qucs/qucsator#47 are wrong, since the 120 V of the source is the peak value and not the RMS as intended in the linked document calculations. |
Concerning CI. MSYS2 seem to have dropped Qt4. One option is to install the official Qt4 package (I used to to it long time ago, it should be on the .appveyor history)... another is to finish the port to Qt5 :). On Travis/OSX you can try to either disable ccache or add it to the brew install list. |
uh, the world is coming to an end 😁 The OSX build log says
so I guess it's something more than |
I will try to get Qt5 back on track. |
Thanks - Qt5 will obviously be the best solution. As mentioned above, the fix here is not yet finished - I need to separate the DC and AC cases due to the fact that AC uses peak values. I'll rebase anyway in the meantime. |
The complex power was wrongly computed as S = V I and by flipping the sign of the reactive power instead of using S = V I*.
so that the voltage noise calculations are correct.
to avoid using calcOperatingPoints(), which should be reserved for non-linear circuits.
to get updated wattmeter test.
bdfbd3c
to
8552ee1
Compare
This is listed as a blocker for 0.0.20. it changes the wattmeter symbol and looks like that will introduce a backwards incompatibility. better defer to 0.0.21? |
Fix Qucs/qucsator#47 .
There where two main issues:
this was easy, just use the correct formula for the power
this required changing the nodes order for the component in the netlist: the probes are a bit of a hack and currently require the voltage sensing to be on the first two nodes, while the wattmeter had the current sensing there.
I also couldn't resist changing a little the probe values output handling to make it feel a little less "hackish" (IMHO).
This goes together with the
qucs-test
update at Qucs/qucs-test#35 .