Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the tests for VASP recipes on Windows in GitHub Actions CI #1920

Open
Andrew-S-Rosen opened this issue Mar 20, 2024 · 0 comments
Open
Labels
github_actions Pull requests that update GitHub Actions code help wanted tests

Comments

@Andrew-S-Rosen
Copy link
Member

What would you like to report?

pytestmark = pytest.mark.skipif(
os.environ.get("GITHUB_ACTIONS") and os.name == "nt",
reason="Skipping this test on Windows in GitHub Actions.",
) # this works locally on Windows, but no clue why it fails on GitHub Actions

This pytestmark should be removed from the test suite. However, doing so causes an error to be raised regarding the VASP_PP_PATH environment variable even though it is set in the conftest.py file below:

@pytest.fixture(autouse=True)
def patch_run(monkeypatch):
from quacc.calculators.vasp.vasp import Vasp
monkeypatch.setenv("VASP_PP_PATH", str(PSEUDO_DIR))

Strangely, the tests run just fine on my Windows machine, but it's not passing on GitHub Actions' Windows machine.

@Andrew-S-Rosen Andrew-S-Rosen added tests help wanted github_actions Pull requests that update GitHub Actions code labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code help wanted tests
Development

Successfully merging a pull request may close this issue.

1 participant