Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement KS test in sqlalchemy expression language API #29

Closed
YYYasin19 opened this issue Jun 29, 2022 · 1 comment · Fixed by #44
Closed

Re-implement KS test in sqlalchemy expression language API #29

YYYasin19 opened this issue Jun 29, 2022 · 1 comment · Fixed by #44
Labels

Comments

@YYYasin19
Copy link
Contributor

Hey,

to track this task, I'd like to open a new issue for the future.
Currently, the Kolmogorov Smirnov test has been implemented in pure SQL, which was already a big win (cf. #28 ).

To get even more independence from different database internals and remove some of the clunky implementation details (e.g. string replacements in mssql table references to fit into the SQL template) it would be helpful to convert the SQL query into sqlalchemy expression language.

This shouldn't be too hard, since:

  • the expression language API has been used throughout the project as well, so there is a lot of referene
  • the test consists mostly of with-query steps and commonly-available functions
  • this is completely seperated from the rest of the project (hence the good first issue label) and consists of "just" translating an SQL query into sqlalchemy expressions

Thanks in advance for whoever might be participating (even if it's just future me).

@jonashaag
Copy link
Contributor

Thanks in advance for whoever might be participating (even if it's just future me).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants