Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Black theme isn't actually black #27

Open
nvllz opened this issue May 3, 2024 · 6 comments
Open

[BUG] Black theme isn't actually black #27

nvllz opened this issue May 3, 2024 · 6 comments
Labels
bug Something isn't working fixed This issue has been fixed and will be closed in the next release P3 This is a nice to have feature that not many users want

Comments

@nvllz
Copy link

nvllz commented May 3, 2024

Describe the bug
There is a black theme option, but most of the time there are some random tones and other (useless) coloring what just defeats the purpose of using pure black theme, the one you would expect to benefit from AMOLED displays.

Expected behavior
I think it is expected that the app respects "true black" and "true black for tweet cards" settings. The latter is not even a thing, as shown below, where you can see that the card is not really black.

Screenshots
947e12ed-fae2-4fa7-a406-c8a4f8ecba41

Smartphone (please complete the following information):

  • Device: n/a
  • OS: n/a
  • Version v3.4.3
@TheHCJ
Copy link
Member

TheHCJ commented May 3, 2024

I cannot reproduce this issue, could you take a screenshot of your Theme settings

@TheHCJ TheHCJ added bug Something isn't working more-information-needed labels May 3, 2024
@nvllz
Copy link
Author

nvllz commented May 3, 2024

How does it look like on your side?

2ac92eb6-17c6-435d-85f4-1708d9c6e6a5

@TheHCJ TheHCJ added help wanted Extra attention is needed and removed more-information-needed labels May 4, 2024
@TheHCJ
Copy link
Member

TheHCJ commented May 4, 2024

I am using the same settings on v3.4.3 and tweet cards are true black

Screenshot_2024-05-04-10-27-44-597_com.thehcj.quacker.jpg

@nvllz
Copy link
Author

nvllz commented May 4, 2024

As you can see below, it's still using some dark accent color. The "Pure Black" setting is expected to turn the tweet cards background black instead (hex #000000).

ac94dd56-ee38-4df2-83bd-daa9466e29e6.mp4

@TheHCJ
Copy link
Member

TheHCJ commented May 4, 2024

Oh thanks, I may of not noticed it. I'll see if it's todo with color harmonisation.

@TheHCJ TheHCJ added the P3 This is a nice to have feature that not many users want label May 4, 2024
@TheHCJ
Copy link
Member

TheHCJ commented May 5, 2024

I think I found the root cause of this, I'll be fixing this in the next release

@TheHCJ TheHCJ added fixed This issue has been fixed and will be closed in the next release and removed help wanted Extra attention is needed labels May 5, 2024
@TheHCJ TheHCJ closed this as completed May 6, 2024
@TheHCJ TheHCJ reopened this May 6, 2024
@TheHCJ TheHCJ closed this as completed May 16, 2024
@TheHCJ TheHCJ reopened this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed This issue has been fixed and will be closed in the next release P3 This is a nice to have feature that not many users want
Projects
None yet
Development

No branches or pull requests

2 participants