-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change launcher to Idea's jar launcher #4
Comments
Urgh I really should change to the idea jar launcher (which I might since the current method has to may problems) . It also looks like their are sponge dependencies marked as compile in your classpath. |
You can basically take any of my recent updated plugins and test. |
Yeah I bet the The way I code most of my plugins atm is with the following.
This does have some downsides:
Positive things are:
I don't know if this would be a good idea for SpongeStart tho. So what do you think? Scratch this messy classlauncher and run it correctly? |
Doesn't bother me, the compiler is fast, especially with Kotlin's incremental compilation.
Do you mean that NMS is obfuscated? It was anyway with SpongeStart. This didn't bother me, too.
Well, good. 👍 I changed kapt to compile and it is still the same error. Doesn't matter since I use a forge server for 1.10.2. I am looking forward to the a new SpongeStart! Is there anything I could help with? |
Wel to make this it is fairly simple:
|
Wait, code hotswapping won't be possible anymore, right? That would be really really sad... |
No, hot swapping will still work. |
Ok, but we are talking about building the plugin to a jar and then copying the jar to the mods folder? |
Yes. But as far I understood IDEA launches the jar in its own kind of wrapper (in debug mode). Which has the ability to replace classes. Even if you aren't actually launching from these classes. So far I know the only requirements is that the name of the class is the same. |
I can't find any documentation on 'IntelliJ jar launcher'. |
Yeah: https://www.jetbrains.com/help/idea/2017.1/run-debug-configuration-jar-application.html. |
Are we going to directly manipulate the xml run configuration files? Like
it is done now?
|
I am not really a fan of it. But apparently it works the best to solve the permission problems (although it makes zero sense to me). |
How I fire up a test server:
The cool thing about this is that the plugin isn't provided as a built jar but in form of the build folder. The Code hotswapping and debugging works. The challenge is here to get the |
Wait can you overwrite the entire run configuration classpath with that? |
It says so here:
|
Whoa. You just found the holy grail to fix this issue. |
How much would you have to change code wise to get it to work? |
Nah still a lot, but the |
A fork/rework of this plugin fixing this issue amongst other things: https://github.com/ImMorpheus/SpongeStart/commit/58805d754295876f1bf2f3fba30651c5695adbb7 |
SpongeForge version:
1.11.2-2227-6.0.0-BETA-2260
SpongeStart version:
1.6.2
Gradle version:
3.1
When running the generated run configuration for the forge server: https://pastebin.com/XMjHmaXt
The text was updated successfully, but these errors were encountered: