Tuple unpacking bug fix in cut finder. #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahim-shehzad
added
bug
garrison
reviewed
May 15, 2024
| @@ -430,12 +430,12 @@ def add_action( | |||
| self, | |||
| action_obj: DisjointSearchAction, | |||
| gate_spec: GateSpec, | |||
| args: tuple | None = None, | |||
| *args: tuple | None, | |||
There was a problem hiding this comment.
I suspect that | None is not actually needed. See e.g. https://stackoverflow.com/a/37032111/1558890
There was a problem hiding this comment.
I wasn't able to look into this carefully but since mypy didn't complain, I went ahead and made the change you suggested (e44b4be).
Pull Request Test Coverage Report for Build 9099874576Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
garrison
approved these changes
May 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 15, 2024
* tuple unpacking bug fix, edit tests and type hints accordingly. * remove extraneous type hint (cherry picked from commit 9d789f7)
garrison
pushed a commit
that referenced
this pull request
May 15, 2024
* tuple unpacking bug fix, edit tests and type hints accordingly. * remove extraneous type hint (cherry picked from commit 9d789f7) Co-authored-by: Ibrahim Shehzad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a tuple unpacking error that arose when the
CutBothWiresaction was invoked as part of the rest of the cut finding workflow. This bug was not noticed at first because the although existing tests called that line, its output was not used in any part of the rest of the workflow. This bug was noticed in the work leading up to #586 which will also add more comprehensive tests for theCutBothWiresaction. The goal of this PR is just to fix this bug and edit the corresponding tests and type hints accordingly.