Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

这个项目维护效果够吐血 #82

Open
huangwei2013 opened this issue Nov 13, 2020 · 3 comments
Open

这个项目维护效果够吐血 #82

huangwei2013 opened this issue Nov 13, 2020 · 3 comments

Comments

@huangwei2013
Copy link
Contributor

huangwei2013 commented Nov 13, 2020

1.告警规则假分页:查询分页是在前端做的;后端接口一次性返回了
2.告警的model实现代码,if else 嵌套了四层
3.大量注释掉的代码
4.相对于镜像版本,源码至少缺少告警抑制(好在还有数据表)

------看到更多的继续来吐血

目前在优化/改写(只是后端;前端无力去折腾,都删掉了)

@FangPengbo
Copy link

容易维护吗?

@huangwei2013
Copy link
Contributor Author

huangwei2013 commented Nov 18, 2020

type Rules struct {
	...
	Op          string `orm:"column(op);size(31)" json:"op"`
	Value       string `orm:"column(value);size(1023)" json:"op"`
        ...

没人说开源这事容易,但既然要做,做的好一点多好

@duxiaowei-jd
Copy link

给360丢人

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants