Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update error parameter from 3 to 2 in tableNameCollector in case of A.A.A #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update error parameter from 3 to 2 in tableNameCollector in case of A.A.A #279

wants to merge 1 commit into from

Conversation

IcePigZDB
Copy link

@IcePigZDB IcePigZDB commented Jul 11, 2022 •
edited
Loading

I'm submitting a...

  • Bug fix
  • Feature
  • Refactoring
  • Added tests
  • Documentation
  • Other (Please describe in detail here)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bug fix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

Current error parameter in validateTableName can not throw exception in case of A.A.A, see testParseSingleBdNameAndTableNameWithError and testParseSingleBdNameAndTableNameWithError2. So I change it to 2 from 3.

Does this PR introduce a breaking change?

  • Yes
  • No

@IcePigZDB IcePigZDB marked this pull request as draft July 11, 2022 03:29
@IcePigZDB IcePigZDB changed the title 3 can not go into error in A.A.A, should be 2 fix: fix parser error in tableNameCollector Jul 11, 2022
@IcePigZDB IcePigZDB changed the title fix: fix parser error in tableNameCollector fix: parser error config in tableNameCollector in case of A.A.A Jul 11, 2022
@IcePigZDB IcePigZDB changed the title fix: parser error config in tableNameCollector in case of A.A.A fix: update error parameter from 3 to 2 in tableNameCollector in case of A.A.A Jul 11, 2022
@IcePigZDB IcePigZDB force-pushed the update-tableNameCollector branch from a99880b to 0413e9c Compare July 11, 2022 03:33
@IcePigZDB IcePigZDB marked this pull request as ready for review July 11, 2022 04:17
@IcePigZDB IcePigZDB mentioned this pull request Jul 11, 2022
Open
@IcePigZDB IcePigZDB force-pushed the update-tableNameCollector branch from 0413e9c to be16932 Compare July 11, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] testParseSingleBdNameAndTableNameWithError in tableNameCollectorTest is not as expected
1 participant
@IcePigZDB