Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the modules directly contact the DB whenever possible #8

Open
marcomicera opened this issue Jan 13, 2021 · 0 comments
Open

Let the modules directly contact the DB whenever possible #8

marcomicera opened this issue Jan 13, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@marcomicera
Copy link
Member

Modules (i.e., builders, analyzers, and reporters) can contact (read and/or write) the graph database in two ways:

  1. Through the Quartermaster orchestrator via the qmstr run ... wrapper (green arrow)
  2. Directly (red arrow)

How should (all kinds of) modules return their results

Contacting the graph database through the Orchestrator causes the latter to be responsible for database management, a task that it shouldn't be responsible for. Therefore, modules should contact the graph database directly (as it already happens for the JSON reporter, purple arrow).

The qmstr run ... wrapper will continue to exist as long as it's more convenient for us.

@marcomicera marcomicera added the enhancement New feature or request label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant