Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear default value for --skip option in itkimage2segimage documentation #4

Open
LennyN95 opened this issue May 1, 2024 · 1 comment
Labels

Comments

@LennyN95
Copy link
Member

LennyN95 commented May 1, 2024

The documentation for the --skip option of itkimage2segimage is enabled by default and, as such, suggests the text.
However, the default value (default: 0) is also documented, which would suggest the opposite.

--skip
     Skip empty slices while encoding segmentation image. By default, empty
     slices will not be encoded, resulting in a smaller output file size.
     (default: 0)
@fedorov
Copy link
Member

fedorov commented May 1, 2024

Maybe the default was changed over time. The code suggests it is enabled by default:

https://github.com/QIICR/dcmqi/blob/master/apps/seg/itkimage2segimage.xml#L59-L64

Should test to confirm the actual behavior...

@fedorov fedorov added the bug label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants