From 932f6a083102143dce517cd4ec25cb05fd552aa9 Mon Sep 17 00:00:00 2001 From: Constance Beguier Date: Tue, 19 Nov 2024 15:31:51 +0100 Subject: [PATCH] Update comments --- src/bundle/commitments.rs | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/bundle/commitments.rs b/src/bundle/commitments.rs index 489e3b2f6..6fd8164be 100644 --- a/src/bundle/commitments.rs +++ b/src/bundle/commitments.rs @@ -31,8 +31,12 @@ pub trait OrchardHash { type OrchardDomain: OrchardDomainCommon; /// Evaluate `orchard_digest` for the bundle as defined in + /// [ZIP-244: Transaction Identifier Non-Malleability][zip244] + /// for OrchardVanilla and as defined in /// [ZIP-226: Transfer and Burn of Zcash Shielded Assets][zip226] + /// for OrchardZSA /// + /// [zip244]: https://zips.z.cash/zip-0244 /// [zip226]: https://zips.z.cash/zip-0226 fn hash_bundle_txid_data>( bundle: &Bundle, @@ -42,6 +46,10 @@ pub trait OrchardHash { impl OrchardHash for OrchardVanilla { type OrchardDomain = OrchardVanilla; + /// Evaluate `orchard_digest` for the bundle as defined in + /// [ZIP-244: Transaction Identifier Non-Malleability][zip244] + /// + /// [zip244]: https://zips.z.cash/zip-0244 fn hash_bundle_txid_data>( bundle: &Bundle, ) -> Blake2bHash { @@ -87,6 +95,10 @@ impl OrchardHash for OrchardVanilla { impl OrchardHash for OrchardZSA { type OrchardDomain = OrchardZSA; + /// Evaluate `orchard_digest` for the bundle as defined in + /// [ZIP-226: Transfer and Burn of Zcash Shielded Assets][zip226] + + /// [zip226]: https://zips.z.cash/zip-0226 fn hash_bundle_txid_data>( bundle: &Bundle, ) -> Blake2bHash { @@ -140,8 +152,12 @@ impl OrchardHash for OrchardZSA { } /// Evaluate `orchard_digest` for the bundle as defined in +/// [ZIP-244: Transaction Identifier Non-Malleability][zip244] +/// for OrchardVanilla and as defined in /// [ZIP-226: Transfer and Burn of Zcash Shielded Assets][zip226] +/// for OrchardZSA /// +/// [zip244]: https://zips.z.cash/zip-0244 /// [zip226]: https://zips.z.cash/zip-0226 pub(crate) fn hash_bundle_txid_data< A: Authorization,