Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized section with real world example #18

Merged
merged 5 commits into from
Mar 15, 2021

Conversation

dschoenig
Copy link
Collaborator

This addresses #14 by replacing the "Other distributions" section with an example based on the same real-world data as the preceding sections. The idea (in terms of instruction) is to show the need for a different probability distribution by checking the model residuals, thereby addressing also #13. A quick check on basis dimension is also included (addresses #12). The old section on "other distributions" has been moved to the end of the presentation.

Fitting method for all models after section 2 has been changed to REML, in accordance with #10.

This branch does not change much in the section on mixed models, since this part requires a more substantial overhaul (#17).

dschoenig and others added 5 commits March 10, 2021 17:47
Fixed a mistake in the script, with the wrong object being called. Clarified challenge 2. Fixed a typo. changed an object name to better fit the material presented.
Copy link
Contributor

@katherinehebert katherinehebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes greatly improve the clarity (and relevance) of the material, and resolve several open issues! Thank you for this excellent contribution 🎉🌟

@katherinehebert katherinehebert merged commit 7d03a16 into main Mar 15, 2021
@katherinehebert katherinehebert deleted the generalized_real_data branch December 6, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Putting the G in GAM Model checking Choice of k Fitting methods (REML should be preferred)
3 participants