Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite: Support for custom JSON encoder #75

Closed
scragly opened this issue Aug 16, 2020 · 0 comments
Closed

Rewrite: Support for custom JSON encoder #75

scragly opened this issue Aug 16, 2020 · 0 comments

Comments

@scragly
Copy link
Member

scragly commented Aug 16, 2020

In line with PR #65 and the recommendation over at #68 (comment) by @Gelbpunkt, we'll try supporting custom JSON encoders in a more tightly integrated / cleaner manner in the new rewrite.

Possible alternative serialisers would be orjson and ujson.

Considerations of note

Due to orjson being a BSON serialiser, and Lavalink not accepting bytes, we should ensure we don't just focus on a basic swap of dumps, as we'll need to convert to unicode when testing orjson but shouldn't attempt to encode where unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants