Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cchardet dependency with faust-cchardet #393

Closed
iarspider opened this issue Apr 18, 2023 · 6 comments
Closed

Replace cchardet dependency with faust-cchardet #393

iarspider opened this issue Apr 18, 2023 · 6 comments
Assignees
Labels
2.0 TwitchIO 2.0 3.x TwitchIO 3.0 Misc

Comments

@iarspider
Copy link

CChardet fails to build for Python 3.11 on Windows link, and the developer is nowhere to be found. There is a forked fixed version faust-cchardet (see this comment) that can be used instead.

@github-actions
Copy link

Hello! Thanks for the issue. If this is a general help question, for a faster response consider joining the official Discord Server

Else if you have an issue with the library please wait for someone to help you here.

@chillymosh
Copy link
Collaborator

chillymosh commented Apr 18, 2023

Just to note, this looks like it was an issue with just 3.11.0
If you build with later versions e.g. 3.11.3 then it allegedly builds correctly.

update
It does build on 3.11 if you install c++ build tools and Cython module.

We're going to discuss this further

@iarspider
Copy link
Author

iarspider commented Apr 18, 2023

Installation of cchardet fails for me with Python 3.11.3 (Windows 10 x64, version from MS Store). Installing cython first, then cchardet works. But just having both in one environment doesn't help, since cchardet doesn't explicitly depend on cython.

@EvieePy
Copy link
Member

EvieePy commented Apr 18, 2023

Hey thanks for bringing up this issue.

We are probably going to make a custom pip index so that these dependencies are available now and for future versions of Python.

I'll update you once we have a working index.

@EvieePy EvieePy self-assigned this Apr 18, 2023
@EvieePy
Copy link
Member

EvieePy commented Apr 19, 2023

Hello, please see #394 for a fix and thanks for bringing this up.

@IAmTomahawkx
Copy link
Member

resolved through the index at https://pip.twitchio.dev/ . Please see the installing page on the master branch for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 TwitchIO 2.0 3.x TwitchIO 3.0 Misc
Projects
None yet
Development

No branches or pull requests

4 participants