adding feedback from Alejandro to clarify instructions #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Upkar Lidder <[email protected]>
|
Looks like there are conflicts to resolve. I can't quite eyeball which is more recent @upkarlidder. Can you please take a pass? |
krook
requested changes
Aug 30, 2021
|
I will check and merge. Thanks @krook. |
|
This still relevant @upkarlidder? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Upkar Lidder [email protected]
@Aquijada52 pls review again. Thank you for your feedback! 🙏🏽
Describe at a high level the solution you're providing
A clear and concise description of what you changed.
Is this a patch, a minor version change, or a major version change
Patch, minor, or major.
Is this related to an open issue?
Please provide the link.
Additional context
Add any other technical detail or considerations here.