fix: run! errors if output is a standalone file #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the `run!` function errors on the README instructions. The idea here is to add an `if` to check it the `dirname` of the `joinpath(pwd(), output)` is a dir instead of throwing error straight away.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
- Coverage 83.98% 83.51% -0.47%
==========================================
Files 5 5
Lines 356 358 +2
==========================================
Hits 299 299
- Misses 57 59 +2 ☔ View full report in Codecov by Sentry. |
MichaelHatherly
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Thanks @storopoli. A test case to cover this one would be great too.
Comment on lines
100
to
107
| function _check_output_dst(s::AbstractString) | ||
| dir = dirname(s) | ||
| isdir(dir) || throw(ArgumentError("directory does not exist: $(dir)")) | ||
| if !isdir(dir) | ||
| _dir = dirname(joinpath(pwd(), s)) | ||
| isdir(_dir) || throw(ArgumentError("directory does not exist: $(dir)")) | ||
| end | ||
| return nothing | ||
| end |
There was a problem hiding this comment.
Suggested change
| function _check_output_dst(s::AbstractString) | |
| dir = dirname(s) | |
| isdir(dir) || throw(ArgumentError("directory does not exist: $(dir)")) | |
| if !isdir(dir) | |
| _dir = dirname(joinpath(pwd(), s)) | |
| isdir(_dir) || throw(ArgumentError("directory does not exist: $(dir)")) | |
| end | |
| return nothing | |
| end | |
| function _check_output_dst(s::AbstractString) | |
| s = abspath(s) | |
| dir = dirname(s) | |
| isdir(dir) || throw(ArgumentError("directory does not exist: $(dir)")) | |
| return nothing | |
| end |
is probably sufficient.
|
Replaced by #5, thanks @storopoli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the
run!function errors on the README instructions.The idea here is to add an
ifto check it thedirnameof thejoinpath(pwd(), output)is a dir instead of throwing error straight away.