Revert use of package extensions #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelHatherly
force-pushed
the
mh/ext-fix
branch
from
16c9cec to
6fb57b1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 51.28% 51.00% -0.29%
==========================================
Files 30 30
Lines 1285 1296 +11
==========================================
+ Hits 659 661 +2
- Misses 626 635 +9 ☔ View full report in Codecov by Sentry. |
Currently experiencing cyclic dependency warnings when using the worker package along with system images that contain packages that are dependencies of the extensions themselves. For the time being until the issue can be resolved we will use use `Requires.jl` for the extension loading mechanism instead.
MichaelHatherly
force-pushed
the
mh/ext-fix
branch
from
6fb57b1 to
f365bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently experiencing cyclic dependency warnings when using the worker package along with system images that contain packages that are dependencies of the extensions themselves. For the time being until the issue can be resolved we will use use
Requires.jlfor the extension loading mechanism instead.