Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify the profile post and put functionality to use presigned links instead of multer file upload. #22

Open
WilliamDormer opened this issue Aug 15, 2022 · 0 comments
Labels
efficiency improvement improves the efficiency of an existing functionality, reducing the computational cost.

Comments

@WilliamDormer
Copy link
Contributor

The current functionality works, but the way it is implemented is not efficient as it turns out. What we do right now, is the photo is uploaded to the nodejs server, and then it is sent from there to the minio container, and the temp file is deleted on the node js server. This works, but it requires moving all this data through the nodejs server unnecessarily. Instead we could use the build in functionality in minio of resigned URLs (as we did on the profile get). This would allow us to send the files directly to mino, bypassing the node js application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efficiency improvement improves the efficiency of an existing functionality, reducing the computational cost.
Projects
Development

No branches or pull requests

1 participant