Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hl1 methodology #950

Merged
merged 7 commits into from
May 21, 2024
Merged

Update Hl1 methodology #950

merged 7 commits into from
May 21, 2024

Conversation

Jennit07
Copy link
Collaborator

@Jennit07 Jennit07 commented May 8, 2024

closes #928 and #906

opening this as a draft for now as i am testing this to make sure the new variables are picked up by the episode and individual files

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Jennit07
Copy link
Collaborator Author

I have tested this to the episode file and i am happy it is working as expected.

To summarise the changes include:

  • Remove filtering if the data is between 90%-105% completeness or 'East Ayrshire'
  • Create a new variable with the completeness percentage compared to SG total assessment decisions (rounded to one decimal place)
  • Create a new variables hl1_12_months_pre_app and hl1_12_months_post_app. This will be a date variable.

I investigated what variables may need to show up in the individual file. I have concluded that the new variables do not need to be there as we do not have record_keydate1 and record_keydate2 available in the individual file. The only homelessness variable we have available is hl1_in_fy. As we do not have record_keydate1 and record_keydate2 available i dont think we need to include the date variables for pre/post application.

Ready to finalise this PR and have this reviewed in preparation for the June update. Thanks

@Jennit07 Jennit07 marked this pull request as ready for review May 10, 2024 10:50

This comment has been minimized.

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (3)

GLS
LCHO
NRS

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the hl1_methodology branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/9175429260/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link
Collaborator

@SwiftySalmon SwiftySalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@SwiftySalmon SwiftySalmon merged commit a8fdecf into June-24-update May 21, 2024
8 of 9 checks passed
@SwiftySalmon SwiftySalmon deleted the hl1_methodology branch May 21, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants