Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest social care ID update #948

Merged
merged 2 commits into from
May 3, 2024
Merged

latest social care ID update #948

merged 2 commits into from
May 3, 2024

Conversation

SwiftySalmon
Copy link
Collaborator

for some reason the latest scid code was overwritten after the march update?? anyway, now it is fixed.

Copy link

github-actions bot commented May 3, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

scid

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the latest_scid branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/8938119201/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@lizihao-anu lizihao-anu self-requested a review May 3, 2024 11:53
@rchlv
Copy link
Collaborator

rchlv commented May 3, 2024

Additional comment from SC team for information:
The period variable in demographics is taken from the header; it is not the same as in other sections and it does not show the period of activity necessarily and shouldn't be used for analysis. It is fine in terms of getting the latest record.
For example, some HSCPs resubmit the whole demographics file each time rather than just new records, so the period would always change to the header data rather than referring to the period of activity. Or in other cases, person A could have activity in Q1, 2 and 3 but only submitted in Q4; this would only show Q4.

Copy link
Collaborator

@rchlv rchlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to merge, thank you.

@rchlv rchlv merged commit fa5cdcd into June-24-update May 3, 2024
1 check passed
@rchlv rchlv deleted the latest_scid branch May 3, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants