Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00 sort bi extracts #837

Merged
merged 14 commits into from
Oct 11, 2023
Merged

00 sort bi extracts #837

merged 14 commits into from
Oct 11, 2023

Conversation

lizihao-anu
Copy link
Contributor

Use fs::file_copy to replace file.copy to improve the speed

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Collaborator

@Jennit07 Jennit07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[1] "source-episode-file-2223.parquet"    "source-individual-file-2223.parquet"
Error: [ENOENT] Failed to copy '/conf/sourcedev/Source_Linkage_File_Updates/2223/source-episode-file-2223.parquet' to '/conf/hscdiip/copy_test/source-episode-file-2223.parquet': no such file or directory

When trying to test one year, i get this error even though i created a copy_test folder in hscdiip. Could this be a permissions issue?

copy_to_hscdiip.R Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (4)

beddays
github
GLS
sourcedev

To accept these unrecognized words as correct, you could run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the 00_Sort_BI_Extracts branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/6393346910/attempts/1'

OR

To have the bot accept them for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (232) from .github/actions/spelling/expect.txt and unrecognized words (4)

Dictionary Entries Covers Uniquely
cspell:k8s/dict/k8s.txt 153 1
cspell:npm/dict/npm.txt 302 1

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:k8s/dict/k8s.txt
          cspell:npm/dict/npm.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''
Errors (2)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 13
ℹ️ no-newline-at-eof 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@lizihao-anu
Copy link
Contributor Author

[1] "source-episode-file-2223.parquet"    "source-individual-file-2223.parquet"
Error: [ENOENT] Failed to copy '/conf/sourcedev/Source_Linkage_File_Updates/2223/source-episode-file-2223.parquet' to '/conf/hscdiip/copy_test/source-episode-file-2223.parquet': no such file or directory

When trying to test one year, i get this error even though i created a copy_test folder in hscdiip. Could this be a permissions issue?

It is a permission issue. We should use "dir.create(file_path)" to create a folder.

@lizihao-anu
Copy link
Contributor Author

Should be good to merge this time

Copy link
Collaborator

@SwiftySalmon SwiftySalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! Will test it tomorrow and see if I get any permission issues

@SwiftySalmon SwiftySalmon self-requested a review October 11, 2023 08:37
Copy link
Collaborator

@SwiftySalmon SwiftySalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good. We can test properly when we get the next boxi extracts

@SwiftySalmon SwiftySalmon added this pull request to the merge queue Oct 11, 2023
Merged via the queue into development with commit d586df3 Oct 11, 2023
12 of 18 checks passed
@SwiftySalmon SwiftySalmon deleted the 00_Sort_BI_Extracts branch October 11, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants