Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of dependencies #580

Closed
Moohan opened this issue Mar 17, 2023 · 2 comments
Closed

Reduce the number of dependencies #580

Moohan opened this issue Mar 17, 2023 · 2 comments
Assignees
Labels
Priority: Low process improvement improves speed or efficiency of running files

Comments

@Moohan
Copy link
Member

Moohan commented Mar 17, 2023

R-CMD-CHECK give a build note commenting on the large number of dependencies we have. It would be sensible to review this and reduce them where possible. We should take a systematic approach and where we are depending on a package but only using it in limited places we should try to re-write the code to not require it.

An obvious example would be to replace glue::glue(...) with stringr::str_glue(...) Since we use {stringr} for many other functions.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This issue is stale because it has been open approximately 5 months with no activity.

@github-actions github-actions bot added the Stale label Sep 4, 2023
@SwiftySalmon SwiftySalmon added the process improvement improves speed or efficiency of running files label Jul 16, 2024
@SwiftySalmon SwiftySalmon self-assigned this Jul 16, 2024
@SwiftySalmon
Copy link
Collaborator

Things that might have alternatives

Uses future or future.callrpackage

  • _targets.R - future::plan(future.callr::callr) this is the only place these two packages are used.

Uses hms package

  • process_extract_cmh.R - keytime2
  • process_extract_gp_ooh - keytime1 and keytime2

Uses R markdown package

  • process_costs_rmd.R - not sure if we use this

Uses scales package

  • costs_care_home.Rmd I don't think we use any of these scripts?
  • costs_district_nursing.Rmd
  • costs_gp_ooh.Rmd
  • costs_home_care.Rmd
  • hc_methodology

Uses stringdist package

  • fill_ch_names.R used for jaccard and cosine matching

Uses tarchetypes package

  • _targets.R

Uses zoo package

  • process_extract_consultations.R - zoo::na.locf I think this is the same as fill but possibly specialised for dates?

@github-actions github-actions bot removed the Stale label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low process improvement improves speed or efficiency of running files
Projects
None yet
Development

No branches or pull requests

3 participants