Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve extract tests output in odd situations #299

Open
Tracked by #932
Moohan opened this issue Jul 19, 2022 · 4 comments
Open
Tracked by #932

Improve extract tests output in odd situations #299

Moohan opened this issue Jul 19, 2022 · 4 comments
Assignees
@Jennit07
Labels
bug Something isn't working Priority: Low Stale Testing Improvements or additions to testing
Milestone
Phase 1 - Setup a...

Comments

@Moohan
Copy link
Member

Moohan commented Jul 19, 2022 •
edited
Loading

Currently, the percent difference is just difference / old value this means that sometimes we get odd values if the difference or old value are zero, or if the old value is missing. R produces NA or Inf in these cases, these don't output to Excel well or consistently. The issue variable will also flag any of these as 'having an issue' which is usually not correct.

Should be a quick update to clean up the values.

On hold at the moment as there are already a couple of outstanding PRs affecting tests #296 #297
@Moohan Moohan added On hold Waiting for something / someone outside of our control Testing Improvements or additions to testing labels Jul 19, 2022
@Moohan Moohan added bug Something isn't working enhancement New feature or request and removed On hold Waiting for something / someone outside of our control labels Aug 5, 2022
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This issue is stale because it has been open approximately 5 months with no activity.

@github-actions github-actions bot added the Stale label Jan 9, 2023
@shintoLamp
Copy link
Contributor

Still relevant so removing stale label

@shintoLamp shintoLamp removed the Stale label Jul 26, 2023
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open approximately 5 months with no activity.

@github-actions github-actions bot added the Stale label Dec 25, 2023
@SwiftySalmon SwiftySalmon mentioned this issue Mar 26, 2024
Closed
20 tasks
@Jennit07 Jennit07 added June-24-update and removed enhancement New feature or request Stale labels Mar 26, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open approximately 5 months with no activity.

@github-actions github-actions bot added the Stale label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jennit07 Jennit07

Labels
bug Something isn't working Priority: Low Stale Testing Improvements or additions to testing
Projects
None yet
Milestone
Phase 1 - Setup and extract processing
Development

No branches or pull requests
4 participants
@Moohan @SwiftySalmon @Jennit07 @shintoLamp