From 53ede24805c28010621d178f5ee7b5261625c1f7 Mon Sep 17 00:00:00 2001
From: James McMahon <james.mcmahon@phs.scot>
Date: Mon, 25 Sep 2023 11:26:10 +0100
Subject: [PATCH] Add tests for `compute_mid_year_age` (#809)

* Add tests for `compute_mid_year_age`

* Remove redundant code

* Update documentation

---------

Co-authored-by: Jennit07 <Jennit07@users.noreply.github.com>
Co-authored-by: Jennit07 <67372904+Jennit07@users.noreply.github.com>
---
 R/compute_mid_year_age.R                   |  2 +-
 man/read_file.Rd                           |  2 +-
 tests/testthat/test-compute_mid_year_age.R | 16 ++++++++++++++++
 3 files changed, 18 insertions(+), 2 deletions(-)
 create mode 100644 tests/testthat/test-compute_mid_year_age.R

diff --git a/R/compute_mid_year_age.R b/R/compute_mid_year_age.R
index 01bfaf5d5..0e2483cf7 100644
--- a/R/compute_mid_year_age.R
+++ b/R/compute_mid_year_age.R
@@ -20,7 +20,7 @@
 compute_mid_year_age <- function(fyyear, dob) {
   age_intervals <- lubridate::interval(
     start = dob,
-    end = as.Date(midpoint_fy(fyyear))
+    end = midpoint_fy(fyyear)
   )
 
   ages <- lubridate::as.period(age_intervals)$year
diff --git a/man/read_file.Rd b/man/read_file.Rd
index b8231218f..1ef351342 100644
--- a/man/read_file.Rd
+++ b/man/read_file.Rd
@@ -14,7 +14,7 @@ read_file(path, col_select = NULL, as_data_frame = TRUE, ...)
 \link[tidyselect:eval_select]{tidy selection specification}
 of columns, as used in \code{dplyr::select()}.}
 
-\item{as_data_frame}{Should the function return a \code{data.frame} (default) or
+\item{as_data_frame}{Should the function return a \code{tibble} (default) or
 an Arrow \link[arrow]{Table}?}
 
 \item{...}{Addition arguments passed to the relevant function.}
diff --git a/tests/testthat/test-compute_mid_year_age.R b/tests/testthat/test-compute_mid_year_age.R
new file mode 100644
index 000000000..a4a542b9e
--- /dev/null
+++ b/tests/testthat/test-compute_mid_year_age.R
@@ -0,0 +1,16 @@
+test_that("Accurately compute mid year age", {
+  expect_equal(
+    compute_mid_year_age("1718", lubridate::make_date("2000")),
+    phsmethods::age_calculate(
+      lubridate::make_date("2000"),
+      lubridate::make_date("2017", 9L, 30L)
+    )
+  )
+  expect_equal(
+    compute_mid_year_age("2021", lubridate::make_date("1999") + 1:1000),
+    phsmethods::age_calculate(
+      lubridate::make_date("1999") + 1:1000,
+      lubridate::make_date("2020", 9L, 30L)
+    )
+  )
+})