Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review {odns} for inspiration #44

Open
2 tasks
Moohan opened this issue Nov 11, 2024 · 2 comments
Open
2 tasks

Review {odns} for inspiration #44

Moohan opened this issue Nov 11, 2024 · 2 comments

Comments

@Moohan
Copy link
Member

Moohan commented Nov 11, 2024

I was made aware of this package - https://github.com/jrh-dev/odns - written by @jrh-dev. It's not been updated in a while and I couldn't install it on the PHS Posit Workbench (possibly due to the R version). Still, it looks like it has some interesting features that are doing things differently to {phsopendata} in some cases.

I think it would be worth a review of the code which will probably generate a list of things to explore or add to this package in the future.

Tasks

Preview Give feedback
@jrh-dev
Copy link

jrh-dev commented Nov 11, 2024

Hey @Moohan , the package was previously on CRAN, it began failing in latest R versions and I haven't had time to maintain it. If it is useful, happy to pass ownership or collaborate.

@Moohan
Copy link
Member Author

Moohan commented Nov 11, 2024

Hey James, the idea is to get phsopendata on CRAN in the near future. I'd be keen to hear anything you think is better about odns for us to try and replicate here though! We've quite a few features to phsopendata recently and there's probably been a lot of changes since you last looked at either package.

I just opened a PR to use httr::RETRY(#45). From a quick look, I also noticed you use package_search... I'm going to add a tasklist to my original comment which I think anyone can add to with interesting bits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants