-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary Table - Replace grideExtra image with flextable #116
base: development
Are you sure you want to change the base?
Conversation
…ory and hence...... Comment out setwd row 21 Change lp_path row 24 to my own working area - this change just for me and ooooops, left an old bit of copy and paste below.
…r that year the markdown crashes - have only hardcoded as temp measure as I think James was looking into a function for this issue/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I've made lots of suggestions, but nothing major 👍
I did notice a mix of pipes - I think |>
is preferred now, so if unless there's something I missed where you're using a special ability of %>%
could you swap them out to make it consistent please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Folks - returning various errors when running - needs double checked at the lines i've highlighted. Format of variables in demographics needs checked and directories may need ironed out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khansh01 I'm just highlighting that I've pushed some significant changes here.
The main changes are that now the USC table works properly, I don't love the fix, but it works for now 😆
@Public-Health-Scotland/list-locality-profiles This still needs checking. There is an output (Orkney West) in the folder. My main thought for improvement would be to 'shrink it down' somehow as the new table(s) takes up a few pages. It would be great to figure out how to make sure each table doesn't spill onto a new page too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the Summary Table/Summary Table Markdown Development.Rmd
file is required / useful?
Created new R Markdown for flextable summary table