Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary Table - Replace grideExtra image with flextable #116

Open
wants to merge 38 commits into
base: development
Choose a base branch
from

Conversation

khansh01
Copy link

@khansh01 khansh01 commented Oct 8, 2024

Created new R Markdown for flextable summary table

@Moohan Moohan changed the base branch from main to development October 8, 2024 14:10
Copy link
Member

@Moohan Moohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I've made lots of suggestions, but nothing major 👍

I did notice a mix of pipes - I think |> is preferred now, so if unless there's something I missed where you're using a special ability of %>% could you swap them out to make it consistent please?

Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary-Table-Markdown-Development.html Outdated Show resolved Hide resolved
Copy link
Contributor

@cfraser2020 cfraser2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Folks - returning various errors when running - needs double checked at the lines i've highlighted. Format of variables in demographics needs checked and directories may need ironed out.

Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Summary Table/Summary Table Dev Flextable.Rmd Outdated Show resolved Hide resolved
Copy link
Member

@Moohan Moohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khansh01 I'm just highlighting that I've pushed some significant changes here.

The main changes are that now the USC table works properly, I don't love the fix, but it works for now 😆

@Public-Health-Scotland/list-locality-profiles This still needs checking. There is an output (Orkney West) in the folder. My main thought for improvement would be to 'shrink it down' somehow as the new table(s) takes up a few pages. It would be great to figure out how to make sure each table doesn't spill onto a new page too.

Copy link
Member

@Moohan Moohan Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the Summary Table/Summary Table Markdown Development.Rmd file is required / useful?

Summary Table/Summary-Table-Markdown.Rmd Outdated Show resolved Hide resolved
@Moohan Moohan changed the title Summary table create r table format Summary Table - Replace grideExtra image with flextable Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summary table - Actual table in the final output
4 participants