Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validation routines that operate on the full design matrix #13

Open
tyarkoni opened this issue May 9, 2016 · 0 comments
Open

Comments

@tyarkoni
Copy link
Collaborator

tyarkoni commented May 9, 2016

Currently we represent the design matrices for each term added to the model as its own array, but we don't have a single representation of all variables in a single design matrix. This makes it hard to apply most validations (e.g., to test for rank deficiency), and is also generally clunky. We should probably move to an architecture that has a separate DesignMatrix class, with each BayesianModel class collecting all DesignMatrix classes. Then we can implement a finalize() call that concatenates all DMs, runs a series of validations, applies convolution, etc. This will also make it easier to abstract the fMRI-specific parts of the package into separate classes so that nipymc can inherit from psypymc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant