From effe86dba81941a255262d0bce6db286d73daf43 Mon Sep 17 00:00:00 2001 From: Felix Kleis Date: Wed, 8 Nov 2023 12:20:00 +0100 Subject: [PATCH] Added changelog items, put changelog into rc.3, removed unnecessary test --- CHANGELOG.md | 53 ++++++++++++------- .../LearningSpaceGoalPanel.tsx | 1 - .../LearningSpaceGoalPanelView.test.tsx | 12 ----- 3 files changed, 33 insertions(+), 33 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index aab1aa4ff..b40837403 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,8 +10,7 @@ The AdLer Engine uses [Semantic Versioning](http://semver.org/). ### Added -- dynamic NPC image matching the 3D model in the space to Adaptivity Element -- bulletpoint list for learning outcomes in LearningSpaceMenu and LearningSpace +- ### Changed @@ -27,7 +26,7 @@ The AdLer Engine uses [Semantic Versioning](http://semver.org/). ### Fixed -- Break Notifications should behave correctly now +- ### Security @@ -35,34 +34,48 @@ The AdLer Engine uses [Semantic Versioning](http://semver.org/). +## Version 2.0.0-rc.3 + +### Added + +- dynamic NPC image matching the 3D model in the space to Adaptivity Element. +- bulletpoint list for learning outcomes in LearningSpaceMenu and LearningSpace. +- Support for Display of Learningelements which are not in the displayed room has been added. +- Learning Goals can now be displayed by clicking the spacescore panel. + +### Fixed + +- Break Notifications should behave correctly now. +- Fontsizes in Adaptivity elements should be displayed correctly now. + ## Version 2.0.0-rc.1 ### Added - Adaptivity Element: - - specific icon for adaptivity element - - 3D representation of NPC - - 2D representation of NPC - - dialog line - - progressmeter - - task selection with icons for question status - - question selection with adaptive hints - - three different diffculties for questions - - question answer mask for single and multiple choice - - responsive UI + - specific icon for adaptivity element. + - 3D representation of NPC. + - 2D representation of NPC. + - dialog line. + - progressmeter. + - task selection with icons for question status. + - question selection with adaptive hints. + - three different diffculties for questions. + - question answer mask for single and multiple choice. + - responsive UI. - Time Spent Element: - - break notification every 30 minutes - - 3 types of break advices for short, medium and long breaks - - 13 different break advices - - randomized selection of break advice - - up to four slides per break notification - - responsive UI + - break notification every 30 minutes. + - 3 types of break advices for short, medium and long breaks. + - 13 different break advices. + - randomized selection of break advice. + - up to four slides per break notification. + - responsive UI. ### Fixed -- bug that prevented update of score panel when scoring h5p elements +- bug that prevented update of score panel when scoring h5p elements. ## Version 1.3.0 - 08.09.2023 diff --git a/src/Components/Core/Presentation/React/LearningSpaceDisplay/LearningSpaceGoalPanel/LearningSpaceGoalPanel.tsx b/src/Components/Core/Presentation/React/LearningSpaceDisplay/LearningSpaceGoalPanel/LearningSpaceGoalPanel.tsx index ea2fc3d6e..ca24951ce 100644 --- a/src/Components/Core/Presentation/React/LearningSpaceDisplay/LearningSpaceGoalPanel/LearningSpaceGoalPanel.tsx +++ b/src/Components/Core/Presentation/React/LearningSpaceDisplay/LearningSpaceGoalPanel/LearningSpaceGoalPanel.tsx @@ -1,6 +1,5 @@ import LearningSpaceGoalPanelController from "./LearningSpaceGoalPanelController"; import LearningSpaceGoalPanelViewModel from "./LearningSpaceGoalPanelViewModel"; -import goalIcon from "../../../../../../Assets/icons/20-goal/goal-icon-nobg.svg"; import useObservable from "../../ReactRelated/CustomHooks/useObservable"; import useBuilder from "~ReactComponents/ReactRelated/CustomHooks/useBuilder"; import BUILDER_TYPES from "~DependencyInjection/Builders/BUILDER_TYPES"; diff --git a/src/Components/CoreTest/Presentation/React/LearningSpaceDisplay/LearningSpaceGoalPanel/LearningSpaceGoalPanelView.test.tsx b/src/Components/CoreTest/Presentation/React/LearningSpaceDisplay/LearningSpaceGoalPanel/LearningSpaceGoalPanelView.test.tsx index 415e6f9e2..80fe4473f 100644 --- a/src/Components/CoreTest/Presentation/React/LearningSpaceDisplay/LearningSpaceGoalPanel/LearningSpaceGoalPanelView.test.tsx +++ b/src/Components/CoreTest/Presentation/React/LearningSpaceDisplay/LearningSpaceGoalPanel/LearningSpaceGoalPanelView.test.tsx @@ -10,18 +10,6 @@ const viewModelMock = new LearningSpaceGoalPanelViewModel(); const controllerMock = new LearningSpaceGoalPanelController(viewModelMock); describe("LearningSpaceGoalPanel", () => { - test("should render", () => { - viewModelMock.goals.Value = ["Lernziel"]; - viewModelMock.isOpen.Value = true; - useBuilderMock([viewModelMock, undefined]); - - const componentUnderTest = render(); - - expect( - componentUnderTest.getByAltText("Learning-Goal-Icon") - ).toBeInTheDocument(); - }); - test("should not render, if isOpen is false", () => { viewModelMock.goals.Value = ["Lernziel"]; viewModelMock.isOpen.Value = false;