Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the workflows to reduce boilerplate code #61

Closed
brian-rose opened this issue Oct 4, 2022 · 2 comments
Closed

Refactor the workflows to reduce boilerplate code #61

brian-rose opened this issue Oct 4, 2022 · 2 comments
Assignees

Comments

@brian-rose
Copy link
Member

With #59 I moved the complicated code that manages the preview deployment (and associated comments in PRs) over to a reusable workflow at https://github.com/ProjectPythiaCookbooks/cookbook-actions/blob/main/.github/workflows/deploy-preview.yaml

Still to do to reduce boilerplate in each Cookbook repo and simplify maintenance:

  • Similarly migrate the code for delete-preview
  • Similarly migrate the code for deploy-book
@brian-rose brian-rose self-assigned this Oct 4, 2022
@brian-rose
Copy link
Member Author

And once that is all done, we will need to push these changes out to all the existing Cookbook repos.

Another example of the need for ProjectPythia/cookbook-gallery#86

@brian-rose
Copy link
Member Author

After much fussing around, this is done.

There may be some further simplifications of these workflows to tackle when we move the cookbook execution to binderbot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant