-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR previews are now replacing the main site #130
Labels
bug
Issues that present a reasonable conviction there is a reproducible bug.
Comments
brian-rose
added
the
bug
Issues that present a reasonable conviction there is a reproducible bug.
label
Oct 25, 2024
I merged #129 which should fix this problem. I will test and find out. |
This problem was solved after merging #131 but now I'm finding that previews are being deleted whenever the main site is redeployed. |
I will open a separate issue for this. We may be misunderstanding the intent of the |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I assume this is a bi-product of #125 but I'm not certain.
PR previews are not being deployed to subdirectories labeled by their PR number. Instead, they are deploying directly to the main site URL. This means that every PR that gets opened is effectively "published" immediately, even if the PR is never merged.
Examples in ProjectPythia/cookbook-template#205 and ProjectPythia/HRRR-AWS-cookbook#35.
The text was updated successfully, but these errors were encountered: