Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR previews are now replacing the main site #130

Closed
brian-rose opened this issue Oct 25, 2024 · 4 comments
Closed

PR previews are now replacing the main site #130

brian-rose opened this issue Oct 25, 2024 · 4 comments
Labels
bug Issues that present a reasonable conviction there is a reproducible bug.

Comments

@brian-rose
Copy link
Member

I assume this is a bi-product of #125 but I'm not certain.

PR previews are not being deployed to subdirectories labeled by their PR number. Instead, they are deploying directly to the main site URL. This means that every PR that gets opened is effectively "published" immediately, even if the PR is never merged.

Examples in ProjectPythia/cookbook-template#205 and ProjectPythia/HRRR-AWS-cookbook#35.

@brian-rose brian-rose added the bug Issues that present a reasonable conviction there is a reproducible bug. label Oct 25, 2024
@brian-rose
Copy link
Member Author

I think that @jbusecke may have already solved this problem with the yet-to-be-merged #126. The current action is not recognizing the input argument BASE_PATH where we are specifying the subdirectory for deployment.

@brian-rose
Copy link
Member Author

I merged #129 which should fix this problem. I will test and find out.

@brian-rose
Copy link
Member Author

This problem was solved after merging #131 but now I'm finding that previews are being deleted whenever the main site is redeployed.

@brian-rose
Copy link
Member Author

I will open a separate issue for this. We may be misunderstanding the intent of the clean-exclude option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that present a reasonable conviction there is a reproducible bug.
Projects
Status: Done
Development

No branches or pull requests

1 participant