Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fulfillBasicOrder is used even if extraData is supplied for a zone contract #671

Open
2 tasks done
etherlect opened this issue Nov 22, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@etherlect
Copy link

Component

Utils

Have you ensured that all of these are up to date?

  • seaport-js
  • Node (minimum v16)

What version of seaport-js are you on?

4.0.4

What function is the bug in?

fullfillOrder

Operating System

None

Describe the bug

When using the library to fulfill advanced orders containing extraData for a zone contract, the fulfillOrder function incorrectly calls fulfillBasicOrder instead of fulfillStandardOrder. As a result, the extraData is not passed to the zone contract.

To address this issue, the logic should ensure that if extraData is provided, fulfillStandardOrder is used.

Relevant code sections:

  • seaport.ts:879
  • utils/fulfill.ts:446: The useAdvanced function should return true when extraData is passed.
@etherlect etherlect added the bug Something isn't working label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant