You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have you ensured that all of these are up to date?
seaport-js
Node (minimum v16)
What version of seaport-js are you on?
4.0.4
What function is the bug in?
fullfillOrder
Operating System
None
Describe the bug
When using the library to fulfill advanced orders containing extraData for a zone contract, the fulfillOrder function incorrectly calls fulfillBasicOrder instead of fulfillStandardOrder. As a result, the extraData is not passed to the zone contract.
To address this issue, the logic should ensure that if extraData is provided, fulfillStandardOrder is used.
Relevant code sections:
seaport.ts:879
utils/fulfill.ts:446: The useAdvanced function should return true when extraData is passed.
The text was updated successfully, but these errors were encountered:
Component
Utils
Have you ensured that all of these are up to date?
What version of seaport-js are you on?
4.0.4
What function is the bug in?
fullfillOrder
Operating System
None
Describe the bug
When using the library to fulfill advanced orders containing
extraData
for a zone contract, thefulfillOrder
function incorrectly callsfulfillBasicOrder
instead offulfillStandardOrder
. As a result, theextraData
is not passed to the zone contract.To address this issue, the logic should ensure that if
extraData
is provided,fulfillStandardOrder
is used.Relevant code sections:
seaport.ts:879
utils/fulfill.ts:446
: TheuseAdvanced
function should returntrue
whenextraData
is passed.The text was updated successfully, but these errors were encountered: