Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss solving method #149

Closed
MichielTukker opened this issue Jul 31, 2024 · 2 comments
Closed

Discuss solving method #149

MichielTukker opened this issue Jul 31, 2024 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@MichielTukker
Copy link
Contributor

We (@vanmeerkerk & @MichielTukker) think we see an issue in the solve method.

  1. The solver production_asset by default prescribes mass_flow. However, when it switches to prescribing Pressure, it doesn't set any equations for it's massflow (connecting to the nodes).
  2. The solver node registers both continuity and a massflow=0 equation. isn't this redundant?
@samvanderzwan
Copy link
Contributor

Ad 1, the production asset either sets both of its pressures or both of it mass flow rates. the mass flow rate should then follow from the system
Ad 2. Nope, the continuity equation is to couple the mass flow rate of the connecting assets to each other. The mass flow rate is zero is for its own mass flow rate.

@MichielTukker MichielTukker added the question Further information is requested label Sep 5, 2024
@vanmeerkerk
Copy link
Contributor

Linked to issue #166 and #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Done
Development

No branches or pull requests

4 participants