-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor mappers #143
Comments
Use EsdlControllerMapper as an example, refactor EsdlEnergySystemMapper to match that pattern |
For every asset - such as the pipe - create a mapper. The mapper will get all the properties from the ESDL-asset and assign them to the asset. For the pipe, this would mean that the enitity pipe is constructed with an inner diameter, roughness, length, etc. The setpoints will not be assigned. |
Goal: to not use the 'EsdlAssetObject' in our own entities, such as the pipe, the consumer, etc. Start with the pipe and then ask for a review.
Take your time! |
Discussed with Michiel. The mappers should be refactored to handle all the esdl logic, This means creating an mapper function for each asset and also parsing the data in that mapper.
This can also help in simplifying some functions.
The text was updated successfully, but these errors were encountered: