Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use either from_iso_format in DatetimeParameter or timestamp() but not both in #74

Open
lfse-slafleur opened this issue Sep 19, 2024 · 0 comments

Comments

@lfse-slafleur
Copy link
Member

lfse-slafleur commented Sep 19, 2024

Currently DatetimeParameter in workflow_types.py uses the ISO format representation for datetimes in the functions from_json_config, from_pb_message and to_pb_message while the functions to_pb_value and from_pb_value use the unix timestamp with datetime.timestamp() function. Both sets of functions convert the datetime into something that is protobuf compatible (albeit that {from,to}_pb_message() functions use a protobuf Struct`) so they should be using the same representation. Right now using different representations is unnecessary and confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant